Fix flaky spill tests#15875
Merged
Merged
Conversation
raunaqmorarka
approved these changes
Jan 27, 2023
findepi
approved these changes
Jan 27, 2023
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
thank you for working on this!
findepi
added
the
no-release-notes
FileSingleStreamSpillerFactory#cleanupOldSpillFiles() will cleanup spill files, which means there is a race condition when multiple spill tests are running using same spill path.
sopel39
force-pushed
the
ks/fix_spill_tests
branch
from
228c4a4 to
d5e8109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSingleStreamSpillerFactory#cleanupOldSpillFiles() will cleanup spill files, which means there is a race condition when multiple spill tests are running
using same spill path.
Fixes: #13288